Review main Merged

72612[TASK] Remove undocumented setting page.pageHeaderFooterTemplateFile

Benni Mack CR +2 V +2 Easy +0 −13 updated 12/10/21, 16:17

Commit message

The TypoScript option "page.pageHeaderFooterTemplate" is removed.

It was introduced in TYPO3 4.5, but never documented,
and is actually overridden by the option "config.pageRendererTemplateFile"
which IS documented, which was also introduced during TYPO3 4.x times.

Both options behave the exact same way.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 12/10/21, 09:07

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 12/10/21, 09:09

  3. core-ci voted on patch set 1 V -1 12/10/21, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20913

  4. Benni Mack uploaded patch set 2 12/10/21, 10:01

  5. core-ci voted on patch set 2 V +1 12/10/21, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20920

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 12/10/21, 12:33

  7. Jochen Roth voted on patch set 2 V +1 CR +1 12/10/21, 16:17

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/10/21, 16:17

  9. Benni Mack merged patch set 3 12/10/21, 16:17