Review main Merged

72613[TASK] Reenable taboverride in grunt copy action

Benjamin Franzke CR +2 V +2 Easy +6 −7 updated 12/14/21, 10:08

Commit message

Instead of disabling the grunt copy,
because of a hardcoded sourcemap reference in the
minified build, we simply use the non
standard build instead and minify the file
ourselves. This results in 25 bytes increased
file size, but that's fine as it allows to auto-update
this library.

While at it, the filename is changed to
reflect the npm module name.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1112

  1. Benjamin Franzke uploaded patch set 1 12/10/21, 10:13

  2. Benjamin Franzke wrote 12/10/21, 10:13

    Topic set to es6
  3. Benjamin Franzke wrote 12/10/21, 10:14

    Topic es6 removed
  4. Benjamin Franzke wrote 12/10/21, 10:14

    Topic set to esm
  5. core-ci voted on patch set 1 V +1 12/10/21, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20921

  6. Andreas Kienast voted on patch set 1 CR +1 12/10/21, 12:43

  7. Benjamin Franzke commented on patch set 1 12/10/21, 12:49

    Testable via: Styleguide TCA Demo > elements basic > 11 > Tab "text" > text_15
  8. Benni Mack voted on patch set 1 V +1 CR +1 12/10/21, 14:44

  9. Oli Bartsch voted on patch set 1 V +1 CR +1 12/13/21, 11:57

  10. Benjamin Franzke voted on patch set 1 V +2 CR +2 12/13/21, 11:58

  11. Benjamin Franzke merged patch set 2 12/13/21, 11:58

  12. Oliver Hader voted on patch set 2 CR +1 12/14/21, 10:08