Review main Merged

72618[BUGFIX] Fix form manager new form creation wizard

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 12/10/21, 16:53

Commit message

The .done() Promise polyfill has been removed in #96263,
therefore .then() needs to be used on promised.

Also adapt the return type declaration
in the global type declarations file.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Benjamin Franzke uploaded patch set 1 12/10/21, 12:50

  2. core-ci voted on patch set 1 V +1 12/10/21, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20936

  3. Andreas Kienast voted on patch set 1 CR +1 12/10/21, 13:45

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 12/10/21, 14:09

  5. Benni Mack voted on patch set 1 CR +1 12/10/21, 14:48

  6. Benni Mack voted on patch set 1 V +2 CR +2 12/10/21, 16:11

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 12/10/21, 16:53

  8. Benjamin Franzke merged patch set 2 12/10/21, 16:53