72619[TASK] Use ES11 import syntax for dynamic typescript imports
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 31
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Element/ImmediateActionElement.ts+3 −3
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/Modifier/Resizable.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/Modifier/Tabbable.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/InputDateTimeElement.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/NavigationContainer.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenu.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DateTimePicker.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DragUploader.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageActions.ts+1 −1
- Build/Sources/TypeScript/form/Resources/Public/TypeScript/Backend/Helper.ts+6 −8
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/SystemMaintainer.ts3+1 −1
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/UpgradeDocs.ts+1 −1
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Router.ts+2 −2
- Build/Sources/TypeScript/rte_ckeditor/Resources/Public/TypeScript/FormEngineInitializer.ts+1 −1
- Build/Sources/TypeScript/t3editor/Resources/Public/TypeScript/Element/CodeMirrorElement.ts+1 −1
- Build/types/TYPO3/index.d.ts+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Element/ImmediateActionElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/Modifier/Resizable.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/Modifier/Tabbable.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/InputDateTimeElement.js+1 −1
Show 11 more files
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/NavigationContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DateTimePicker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DragUploader.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/Backend/Helper.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Settings/SystemMaintainer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/UpgradeDocs.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Router.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/FormEngineInitializer.js+1 −1
- typo3/sysext/t3editor/Resources/Public/JavaScript/Element/CodeMirrorElement.js+3 −3
Review log 1317
-
Benjamin Franzke uploaded patch set 1 12/10/21, 12:51
-
Benjamin Franzke wrote 12/10/21, 12:51
Topic set to esm -
core-ci voted on patch set 1 V +1 12/10/21, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20937
-
Jochen Roth rebased onto patch set 2 12/10/21, 14:16
-
core-ci voted on patch set 2 V +1 12/10/21, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20942
-
Benni Mack commented on patch set 2 12/10/21, 14:49
SystemMaintainer.ts:35this one? -
Benjamin Franzke commented on patch set 2 12/10/21, 14:59
SystemMaintainer.ts:35Replyyea, sorry, wanted to add a sentence to the commit message that top.require is excluded as these cases can't be transpiled when changed to top.import. And they wouldn't work with native ES6 (there is nothing like top.import): TypeError: top.import is not a function Seems I forgot to mention that, will do. We'll rather need a messaging api between the frames that allows to load top-level modules via import(). Therefore I'd leave that out of this patch. -
Benjamin Franzke updated the commit message in patch set 3 12/10/21, 15:04
-
Benjamin Franzke commented on patch set 3 12/10/21, 15:04
SystemMaintainer.ts:35ReplyDone -
core-ci voted on patch set 3 V +1 12/10/21, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20945
-
Benjamin Franzke uploaded patch set 4 12/10/21, 23:59
-
core-ci voted on patch set 4 V +1 12/11/21, 00:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20972
-
Jochen Roth voted on patch set 4 V +1 CR +1 12/13/21, 10:02
-
Benni Mack voted on patch set 4 CR +1 12/13/21, 11:44
-
Benni Mack voted on patch set 4 V +1 12/13/21, 11:54
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 12/13/21, 12:28
-
Benjamin Franzke merged patch set 5 12/13/21, 12:28