Review main Merged

72621[BUGFIX] Set mute=1 if autoplay=1 for rendering youtube videos

Georg Ringer CR +2 V +2 Easy +6 −4 updated 01/04/22, 12:17

Commit message

The option "autoplay" only works if "mute" is enabled. See
https://developer.chrome.com/blog/autoplay/ for reference.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Daniel Haupt +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Haupt +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1517

  1. Georg Ringer uploaded patch set 1 12/10/21, 13:08

  2. Georg Ringer commented on patch set 1 12/10/21, 13:08

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 12/10/21, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20939

  4. Oliver Klee voted on patch set 1 CR +1 12/10/21, 16:40

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 12/11/21, 16:02

  6. Daniel Haupt voted on patch set 1 V +1 CR +1 12/28/21, 10:59

  7. Stefan Bürk voted on patch set 1 V +1 CR +1 12/30/21, 13:20

  8. Andreas Kienast commented on patch set 1 CR -1 12/30/21, 14:03

    I'd like to have https://developer.chrome.com/blog/autoplay/ referenced in a comment in case somebody in the future wonders why mute=1 is set magically. Will update the patch.
  9. Andreas Kienast uploaded patch set 2 12/30/21, 14:05

  10. Andreas Kienast voted on patch set 2 V +1 CR +1 12/30/21, 14:05

  11. Oliver Klee voted on patch set 2 CR +1 12/30/21, 14:09

  12. core-ci voted on patch set 2 V +1 12/30/21, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21519

  13. Stefan Bürk voted on patch set 2 V +1 CR +1 12/30/21, 14:24

  14. Daniel Haupt voted on patch set 2 V +1 CR +1 12/30/21, 14:58

  15. Christian Kuhn commented on patch set 2 CR +1 01/04/22, 12:10

    it seems firefox does the same - i'd say it's general agreement among browsers to block autoplay+audio combination.
  16. Christian Kuhn voted on patch set 2 V +2 CR +2 01/04/22, 12:17

  17. Christian Kuhn merged patch set 3 01/04/22, 12:17