Review main Merged

72623[BUGFIX] Use already initialized user in OpenDocumentService

Oli Bartsch CR +2 V +2 Easy +12 −20 updated 12/10/21, 14:05

Commit message

In #96318 the call to `$backendUser->start()` was removed
in OpenDocumentService. This then led to an exception, in
case a not fully initialized backend user object is used to
call `getModuleData()`.

This is fixed by no longer using an own backend user
instance, but instead accessing the already initialized
global object.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 12/10/21, 13:49

  2. Benni Mack voted on patch set 1 V +1 CR +1 12/10/21, 14:04

  3. core-ci voted on patch set 1 V +1 12/10/21, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20941

  4. Jochen Roth voted on patch set 1 V +1 CR +1 12/10/21, 14:05

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 12/10/21, 14:05

  6. Oli Bartsch merged patch set 2 12/10/21, 14:05