Review main Merged

72624[TASK] Log site configuration actions

Oli Bartsch CR +2 V +2 Normal +49 −2 updated 12/13/21, 11:46

Commit message

Actions to site configurations, in the site
configuration module, are now properly
logged with the new logging type "site".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1215

  1. Oli Bartsch uploaded patch set 1 12/10/21, 15:04

  2. Benni Mack commented on patch set 1 12/10/21, 15:10

    Site.php:25

    CREATE UPDATE RENAME DELETE
  3. core-ci voted on patch set 1 V +1 12/10/21, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20946

  4. Oli Bartsch uploaded patch set 2 12/10/21, 17:11

  5. Oli Bartsch commented on patch set 2 12/10/21, 17:11

    Site.php:25 Reply

    Done
  6. core-ci voted on patch set 2 V +1 12/10/21, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20952

  7. Oli Bartsch uploaded patch set 3 12/10/21, 21:55

  8. Oli Bartsch rebased onto patch set 4 12/10/21, 22:02

  9. core-ci voted on patch set 4 V +1 12/10/21, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20967

  10. Stefan Bürk commented on patch set 4 12/11/21, 14:20

    SiteConfigurationController.php:435

    On rename, this will log an "renamed" AND an "updated" entry (two) for the same action, which I find is a little noisy. A rename implies an update. Instead if doing the rename check/log before, do it as additional check to decide if renamed or updated should be logged in L434, to have only one log entry. Or was this intended ?
  11. Oli Bartsch commented on patch set 4 12/13/21, 09:24

    SiteConfigurationController.php:435 Reply

    Actually, this seems to be correct for me. RENAME only refers to the site configurations file name, while UPDATE refers to the actual site configuration content. In case someone renames the file while also updating the content, this should IMO produce two separate log entries.
  12. Stefan Bürk commented on patch set 4 V +1 CR +1 12/13/21, 11:14

    SiteConfigurationController.php:435 Reply

    Would say that's a point which could be discussed to death. But I can live with that argumentation. And renaming site-config (with concurent update) should not happen that much often, so okay.
  13. Benni Mack voted on patch set 4 V +1 CR +1 12/13/21, 11:40

  14. Oli Bartsch voted on patch set 4 V +2 CR +2 12/13/21, 11:45

  15. Oli Bartsch merged patch set 5 12/13/21, 11:46