Review main Merged

72626[TASK] Re-enable jquery.autocomplete in grunt copy action

Benjamin Franzke CR +2 V +2 Normal +38 −22 updated 12/14/21, 10:04

Commit message

Add a patch file for jquery.autocomplete that contains
the custom TYPO3 patches added in #79938 and #70988.

Enable the grunt copy action to ensure that mass
package-upgrades like #92419 do not miss to update
our local fork. A non-applying patch will produce an
error during upgrade, while a local fork is silently
ignored.

Also, pin devbridge-autocomplete to the version that is actually used
(updated last time in #70988):

  yarn add devbridge-autocomplete@~1.3.0

The patch file has been generated via:

  cp typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery.autocomplete.js \
     Build/node_modules/devbridge-autocomplete/dist/jquery.autocomplete.js
  patch-package devbridge-autocomplete

Note: The version line change is removed and the indentation
(tabs vs spaces) is fixed, as it rather limits updatability,
therefore the resulting javascript file format is slightly changed.
No functional change.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 5

Review log 1219

  1. Benjamin Franzke uploaded patch set 1 12/10/21, 19:29

  2. Benjamin Franzke wrote 12/10/21, 19:29

    Topic set to esm
  3. core-ci voted on patch set 1 V -1 12/10/21, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20953

  4. Benjamin Franzke uploaded patch set 2 12/10/21, 20:26

  5. core-ci voted on patch set 2 V -1 12/10/21, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20955

  6. core-ci commented on patch set 2 12/10/21, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20955

  7. core-ci commented on patch set 2 12/10/21, 21:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20955

  8. Benjamin Franzke uploaded patch set 3 12/10/21, 21:09

  9. Benjamin Franzke rebased onto patch set 4 12/10/21, 21:25

  10. core-ci voted on patch set 3 V -1 12/10/21, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20959

  11. core-ci voted on patch set 4 V +1 12/10/21, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20960

  12. Oli Bartsch updated the commit message in patch set 5 12/10/21, 22:16

  13. Oli Bartsch commented on patch set 5 12/10/21, 22:17

    devbridge-autocomplete+1.3.0.patch:10

    Shouldn't this be "added value parameter"?
  14. core-ci voted on patch set 5 V +1 12/10/21, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20970

  15. Benjamin Franzke commented on patch set 5 12/10/21, 22:31

    devbridge-autocomplete+1.3.0.patch:10 Reply

    I guess the comment meant that "index" is added to options.formatGroup, and therefore index is now the third parameter to be able to pass that value (the previous "index" parameter was basically unchanged. But you are right, this is a bit fishy, but I don't know the exact reason, and really only copied those comments to keep the patch mainly a build-cleanup.
  16. Benni Mack voted on patch set 5 V +1 CR +1 12/13/21, 20:23

  17. Oliver Hader voted on patch set 5 V +2 CR +2 12/14/21, 10:03

  18. Oliver Hader commented on patch set 5 12/14/21, 10:04

    devbridge-autocomplete+1.3.0.patch:10 Reply Unresolved

    Actually prev. `index` became `value` and new `index` was added... fishy, bit somehow "correct"... When looking to the resulting file, it's looks okay.
  19. Oliver Hader merged patch set 6 12/14/21, 10:04