72626[TASK] Re-enable jquery.autocomplete in grunt copy action
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +1
- core-ci +1 CI
Issues 5
Files 5
Review log 1219
-
Benjamin Franzke uploaded patch set 1 12/10/21, 19:29
-
Benjamin Franzke wrote 12/10/21, 19:29
Topic set to esm -
core-ci voted on patch set 1 V -1 12/10/21, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20953
-
Benjamin Franzke uploaded patch set 2 12/10/21, 20:26
-
core-ci voted on patch set 2 V -1 12/10/21, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20955
-
core-ci commented on patch set 2 12/10/21, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20955
-
core-ci commented on patch set 2 12/10/21, 21:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20955
-
Benjamin Franzke uploaded patch set 3 12/10/21, 21:09
-
Benjamin Franzke rebased onto patch set 4 12/10/21, 21:25
-
core-ci voted on patch set 3 V -1 12/10/21, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20959
-
core-ci voted on patch set 4 V +1 12/10/21, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20960
-
Oli Bartsch updated the commit message in patch set 5 12/10/21, 22:16
-
Oli Bartsch commented on patch set 5 12/10/21, 22:17
devbridge-autocomplete+1.3.0.patch:10Shouldn't this be "added value parameter"? -
core-ci voted on patch set 5 V +1 12/10/21, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20970
-
Benjamin Franzke commented on patch set 5 12/10/21, 22:31
devbridge-autocomplete+1.3.0.patch:10ReplyI guess the comment meant that "index" is added to options.formatGroup, and therefore index is now the third parameter to be able to pass that value (the previous "index" parameter was basically unchanged. But you are right, this is a bit fishy, but I don't know the exact reason, and really only copied those comments to keep the patch mainly a build-cleanup. -
Benni Mack voted on patch set 5 V +1 CR +1 12/13/21, 20:23
-
Oliver Hader voted on patch set 5 V +2 CR +2 12/14/21, 10:03
-
Oliver Hader commented on patch set 5 12/14/21, 10:04
devbridge-autocomplete+1.3.0.patch:10Reply UnresolvedActually prev. `index` became `value` and new `index` was added... fishy, bit somehow "correct"... When looking to the resulting file, it's looks okay. -
Oliver Hader merged patch set 6 12/14/21, 10:04