72627[!!!][FEATURE] Automatically register ContextMenu item providers
Commit message
Show more Show less
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/AbstractProvider.php+7 −11
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/ItemProvidersRegistry.phpnew+47 −0
- typo3/sysext/backend/Classes/ContextMenu/ContextMenu.php+15 −20
- typo3/sysext/backend/Configuration/Services.php+2 −0
- typo3/sysext/backend/Configuration/Services.yaml3+8 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96333-AutoConfigurationOfContextMenuItemProviders.rstnew+112 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96333-ImproveContextMenuItemProviderRegistration.rstnew+36 −0
- typo3/sysext/filelist/ext_localconf.phpdeleted+0 −9
- typo3/sysext/form/ext_localconf.php+0 −7
- typo3/sysext/impexp/ext_localconf.phpdeleted+0 −9
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
Review log 1215
-
Oli Bartsch uploaded patch set 1 12/10/21, 20:12
-
Benjamin Franzke wrote 12/10/21, 20:22
Topic set to di -
core-ci voted on patch set 1 V -1 12/10/21, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20954
-
Benjamin Franzke rebased onto patch set 2 12/10/21, 21:28
-
core-ci voted on patch set 2 V +1 12/10/21, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20963
-
Benni Mack voted on patch set 2 CR +1 12/13/21, 11:41
-
Benni Mack voted on patch set 2 V +1 12/13/21, 18:42
-
Benjamin Franzke commented on patch set 2 CR -1 12/13/21, 19:41
Services.yaml:31I don't think ContextMenu needs to be shared. It doesn't contain state. -
Benjamin Franzke uploaded patch set 3 12/13/21, 19:45
-
Benjamin Franzke commented on patch set 3 12/13/21, 19:45
Services.yaml:31ReplyDone -
Benjamin Franzke commented on patch set 3 12/13/21, 19:47
Services.yaml:31ReplyNote: Other cases like ModuleTemplateFactory are defined as shared: false as well, but they are also not required to be shared: false. But of course sth for another cleanup patch, justed wanted to mention why I'd to it differently here. -
core-ci voted on patch set 3 V +1 12/13/21, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21043
-
Benni Mack voted on patch set 3 V +1 CR +1 12/13/21, 20:09
-
Oli Bartsch voted on patch set 3 V +2 CR +2 12/13/21, 20:15
-
Oli Bartsch merged patch set 4 12/13/21, 20:15