Review main Merged

72631[BUGFIX] Cast $uid to int in ConditionMatcher

Oli Bartsch CR +2 V +2 Easy +1 −2 updated 12/13/21, 11:44

Commit message

With #95258 `ConditionMatcher->getPageIdByRecord()`
got type hinted. Therefore, the $uid has to be casted to
int before passing it to the method.

Additionally, a left over type cast in the method itself
is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 12/10/21, 23:02

  2. core-ci voted on patch set 1 V +1 12/10/21, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20971

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 12/11/21, 10:14

  4. Oliver Klee voted on patch set 1 CR +1 12/11/21, 12:18

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 12/11/21, 14:00

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 12/13/21, 11:44

  7. Oli Bartsch merged patch set 2 12/13/21, 11:44