Review main Abandoned

72633[WIP][TASK] Pass request and return response in PageRenderer

Benjamin Franzke CR 0 V 0 Normal +89 −82 updated 07/04/23, 12:04

Commit message

Also add a method renderResponse() to ModuleTemplate
to be able to pass the response down the stack.

This for PageRenderer to be able to add headers,
e.g. for content security policy, matching added
scripts, later on.

Executed commands
  find typo3 -name '*.php' -exec sed -i \
    's/new HtmlResponse(\$this->moduleTemplate->renderContent())/$this->moduleTemplate->renderResponse()/' {} +

  Build/Scripts/cglFixMyCommit.sh

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 37

Show 17 more files

Review log 34

  1. Benjamin Franzke uploaded patch set 1 12/11/21, 06:29

  2. Benjamin Franzke wrote 12/11/21, 06:30

    Topic set to esm
  3. core-ci voted on patch set 1 V -1 12/11/21, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20978

  4. Benjamin Franzke abandoned the change 07/04/23, 12:04

    csrf is done, not needed right now