Review main Merged

72635[TASK] Remove leftover TSFE factory method

Nikita Hovratov CR +2 V +2 Easy +0 −29 updated 12/11/21, 19:46

Commit message

Since the removal of the container entry, the
factory method
TypoScriptFrontendController->getGlobalInstance() is
obsolete.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Nikita Hovratov uploaded patch set 1 12/11/21, 11:44

  2. core-ci voted on patch set 1 V -1 12/11/21, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20982

  3. Nikita Hovratov uploaded patch set 2 12/11/21, 11:47

  4. core-ci voted on patch set 2 V +1 12/11/21, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20983

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 12/11/21, 12:10

  6. Oliver Klee voted on patch set 2 CR +1 12/11/21, 12:18

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 12/11/21, 14:06

  8. Benjamin Franzke commented on patch set 2 V +2 CR +2 12/11/21, 19:46

    Absolutely, thanks.
  9. Benjamin Franzke merged patch set 3 12/11/21, 19:46