Review main Merged

72636[TASK] Add tests for DataHandler->applyFiltersToValues

Nikita Hovratov CR +2 V +2 Normal +111 −3 updated 12/13/21, 11:43

Commit message

This adds missing tests for the TCA "filter" option
for group, select and inline.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1417

  1. Nikita Hovratov uploaded patch set 1 12/11/21, 19:16

  2. core-ci voted on patch set 1 V +1 12/11/21, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20987

  3. Stefan Bürk commented on patch set 1 12/11/21, 19:49

    UserOddNumberFilter.php:18

    Can we use the full path namespace here, as this looks kinda fishy, at least in the use statement of the test class. ``` namespace TYPO3\CMS\Core\Tests\Unit\DataHandling\Fixtures; ``` If I'm right, this would make the addition as classmap in 'composer.json' superfluous - or not ?
  4. Nikita Hovratov uploaded patch set 2 12/12/21, 10:00

  5. Nikita Hovratov commented on patch set 2 12/12/21, 10:01

    UserOddNumberFilter.php:18 Reply

    Done
  6. core-ci voted on patch set 2 V +1 12/12/21, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21002

  7. Stefan Bürk commented on patch set 2 V +1 CR +1 12/12/21, 11:15

    UserOddNumberFilter.php:18 Reply

    Thx.
  8. Benni Mack voted on patch set 2 V +2 CR +2 12/12/21, 20:40

  9. Benni Mack commented on patch set 2 V 0 CR 0 12/12/21, 20:41

    I think we should backport this to v11 as well, as this also addresses some TCA-related PHP 8 issues. agreed?
  10. Oliver Klee commented on patch set 2 12/12/21, 20:54

    Reply

    +1
  11. Nikita Hovratov updated the commit message in patch set 3 12/12/21, 20:59

  12. Nikita Hovratov commented on patch set 3 12/12/21, 21:01

    Reply

    Done
  13. Oliver Klee wrote 12/12/21, 21:08

    Removed cc Oliver Klee.
  14. core-ci voted on patch set 3 V +1 12/12/21, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21005

  15. Stefan Bürk voted on patch set 3 V +1 CR +1 12/12/21, 23:28

  16. Benni Mack voted on patch set 3 V +2 CR +2 12/13/21, 11:43

  17. Benni Mack merged patch set 4 12/13/21, 11:43