Review main Merged

72639[BUGFIX] Fix undefined key warning when opening record list

Robert Kärner CR +2 V +2 Easy +1 −1 updated 12/13/21, 14:08

Commit message

Access to array key $this->pageRow['editlock'] must be protected
with the neccessary fallback to false.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Robert Kärner +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Robert Kärner +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Robert Kärner uploaded patch set 1 12/13/21, 07:13

  2. Robert Kärner commented on patch set 1 12/13/21, 07:15

    DatabaseRecordList.php:2206

    FYI: PHPStorm showed a suggestion: `Can be replaced with '$table === 'pages' || !$this->pageRow['editlock']'` and I agreed, so I changed it as well.
  3. core-ci voted on patch set 1 V +1 12/13/21, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21017

  4. Stefan Bürk commented on patch set 1 12/13/21, 11:19

    DatabaseRecordList.php:2206 Reply

    Please add () arround the left condition - to make it obious, as this not a often seen construct (yet). ``` return ($table === 'pages') || !($this->pageRow['editlock'] ?? false); ```
  5. Stefan Bürk uploaded patch set 2 12/13/21, 12:15

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 12/13/21, 12:16

  7. Robert Kärner voted on patch set 2 V +1 CR +1 12/13/21, 12:29

  8. core-ci voted on patch set 2 V +1 12/13/21, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21026

  9. Oliver Klee voted on patch set 2 CR +1 12/13/21, 13:37

  10. Benni Mack voted on patch set 2 V +2 CR +2 12/13/21, 14:08

  11. Benni Mack merged patch set 3 12/13/21, 14:08