72645[BUGFIX] Pass default/override values to FormSelectTreeAjaxController
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/CategoryElement.ts+2 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTreeElement.ts+2 −0
- typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php+6 −0
- typo3/sysext/backend/Classes/Form/Element/CategoryElement.php+2 −0
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php3+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/CategoryElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+1 −1
Review log 1012
-
Oli Bartsch uploaded patch set 1 12/13/21, 15:08
-
core-ci voted on patch set 1 V +1 12/13/21, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21037
-
Nikita Hovratov commented on patch set 1 V +1 12/13/21, 19:40
Works as expected.If you happen to push another patch, can you squish that extra white space ? :)SelectTreeElement.php:175Shouldn't this also be useHtmlEntities=false ? (Correct me if I'm wrong). -
Oli Bartsch commented on patch set 1 12/13/21, 20:30
SelectTreeElement.php:175ReplyNo, this is correct. All values should be htmlspecialchar'd. This is only set to FALSE in the CategoryElement, because those values are added later on using GeneralUtility::implodeAttributes(), with the second parameter (xhtmlSafe) set to TRUE. -
Nikita Hovratov commented on patch set 1 CR +1 12/13/21, 21:00
SelectTreeElement.php:175ReplyAck -
Benni Mack voted on patch set 1 V +1 CR +1 12/14/21, 08:31
-
Benni Mack updated the commit message in patch set 2 12/14/21, 08:32
-
core-ci voted on patch set 2 V +1 12/14/21, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21064
-
Benni Mack commented on patch set 2 V +1 CR +1 12/14/21, 08:50
Reply
Done -
Nikita Hovratov voted on patch set 2 V +1 CR +1 12/14/21, 08:57
-
Oli Bartsch voted on patch set 2 V +2 CR +2 12/14/21, 09:33
-
Oli Bartsch merged patch set 3 12/14/21, 09:33