Review main Merged

72646[TASK] Add missing jquery imports

Benjamin Franzke CR +2 V +2 Easy +24 −8 updated 12/14/21, 05:59

Commit message

Some modules are missing jquery imports.
This currently works as jquery is exposed in
the global object (window.$ and window.jQuery)
and likely loaded by some other module.

Still, loading may fail when jquery hasn't
been loaded by another module, therefore
these occurences are fixed and the type
declarations are patched to avoid marking
jquery available as global object (therefore
typescript will complain when using jQuery or
$ without importing it).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 78

  1. Benjamin Franzke uploaded patch set 1 12/13/21, 18:01

  2. Benjamin Franzke wrote 12/13/21, 18:02

    Topic set to esm
  3. core-ci voted on patch set 1 V +1 12/13/21, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21040

  4. Benni Mack voted on patch set 1 V +1 CR +1 12/13/21, 18:39

  5. Oliver Hader voted on patch set 1 CR +1 12/13/21, 18:39

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 12/13/21, 23:16

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 12/14/21, 05:59

  8. Benjamin Franzke merged patch set 2 12/14/21, 05:59