Review main Merged

72648[BUGFIX] Avoid duplicate results in HMENU with workspaces

Benni Mack CR +2 V +2 Normal +179 −60 updated 12/16/21, 13:35

Commit message

HMENU special="directory" and special="updated" did not
use PageRepository directly, which led to duplicate
entries with workspaces.

This change does not use "$cObj->exec_..." anymore
and fixes all problems.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1217

  1. Benni Mack uploaded patch set 1 12/13/21, 21:14

  2. core-ci voted on patch set 1 V -1 12/13/21, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21047

  3. Benni Mack uploaded patch set 2 12/13/21, 22:49

  4. core-ci voted on patch set 2 V -1 12/14/21, 00:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21050

  5. Benni Mack rebased onto patch set 3 12/14/21, 08:51

  6. core-ci voted on patch set 3 V +1 12/14/21, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21068

  7. Benni Mack uploaded patch set 4 12/15/21, 14:39

  8. core-ci voted on patch set 4 V +1 12/15/21, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21133

  9. Benni Mack uploaded patch set 5 12/15/21, 15:51

  10. core-ci voted on patch set 5 V +1 12/15/21, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21138

  11. Oli Bartsch voted on patch set 5 CR +1 12/15/21, 21:01

  12. Oli Bartsch voted on patch set 5 V +1 12/16/21, 11:22

  13. Jochen Roth voted on patch set 5 V +1 CR +1 12/16/21, 12:07

  14. Christian Kuhn voted on patch set 5 CR +1 12/16/21, 12:26

  15. Benni Mack voted on patch set 5 V +2 CR +2 12/16/21, 12:36

  16. Benni Mack merged patch set 6 12/16/21, 12:36

  17. Oliver Hader voted on patch set 6 CR +1 12/16/21, 13:35