Review main Abandoned

72656[WIP][BUGFIX] Cleanup exception inheritance

Helmut Hummel CR 0 V 0 Easy +18 −17 updated 12/16/21, 06:44

Commit message

The purpose of \TYPO3\CMS\Core\Error\Exception is,
as stated in the class description, to represent
a PHP error that occurred. As such, it should rather
contain location information (error type, file and line),
like the PHP internal \ErrorException does.

For sure though, other exception within TYPO3 should not
inherit from it as a base exception, but rather inherit from

\TYPO3\CMS\Core\Exception

Review

  • Code review CR 0
  • Verified V 0

Files 13

Review log 45

  1. Helmut Hummel uploaded patch set 1 12/14/21, 14:05

  2. core-ci voted on patch set 1 V +1 12/14/21, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21084

  3. Christian Kuhn commented on patch set 1 12/15/21, 14:04

    maybe mark that exception final?
  4. Helmut Hummel commented on patch set 1 12/16/21, 06:44

    Reply Unresolved

    good idea to mark the error exception final in the end!
  5. Helmut Hummel abandoned the change 12/16/21, 06:44

    Abandon for now