Review main Merged

72659[BUGFIX] Always return a string for PHP 8.1

Chris Müller CR +2 V +2 Easy +17 −13 updated 12/20/21, 00:35

Commit message

The following deprecation occurred in PHP 8.1:
PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated.

This happens in various places:
* Using stdWrap_field() or in stdWrap() places
* BackendUtility (e.g. new IRRE elements)
* ExtensionManager

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Chris Müller uploaded patch set 1 12/14/21, 16:56

  2. core-ci voted on patch set 1 V +1 12/14/21, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21101

  3. Benni Mack commented on patch set 1 CR -1 12/14/21, 17:19

    I do have a few more...
  4. Benni Mack uploaded patch set 2 12/14/21, 19:58

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/14/21, 19:58

  6. core-ci voted on patch set 2 V +1 12/14/21, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21103

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 12/15/21, 13:56

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/15/21, 14:11

  9. Benni Mack merged patch set 3 12/15/21, 14:11

  10. Helmut Hummel commented on patch set 3 12/20/21, 00:35

    At least for the changes in Package this is a post -1 from my side. These values can not be set in the package and should be tracked internally as null values then instead of empty string