Review main Merged

72661[TASK] Better performance for LiveSearch

Stefan Froemken CR +2 V +2 Easy +26 −11 updated 01/05/22, 13:59

Commit message

We removed the SQL query on pages (column: pid) for TYPO3
administrators, because this group of people has access to
all pages anyway. Especially in large TYPO3 instances
the collection of all pages UIDs took a lot of time.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Froemken uploaded patch set 1 12/15/21, 13:43

  2. core-ci voted on patch set 1 V +1 12/15/21, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21125

  3. Stefan Froemken commented on patch set 1 12/15/21, 14:01

    Tested with following query string: "#22690" on a system with more than 30.000 pages Without this patch: 14.3 seconds With patch: 105ms
  4. Christian Kuhn uploaded patch set 2 01/05/22, 13:15

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 01/05/22, 13:16

  6. core-ci voted on patch set 2 V +1 01/05/22, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21645

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 01/05/22, 13:38

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 01/05/22, 13:59

  9. Christian Kuhn merged patch set 3 01/05/22, 13:59