Review main Merged

72662[TASK] Avoid obsolete if in EditDocumentController

Christian Kuhn CR +2 V +2 Easy +5 −10 updated 12/15/21, 17:21

Commit message

$command being either 'new' or 'edit' is tested in
a previous if() a couple of lines above already.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/15/21, 14:07

  2. core-ci voted on patch set 1 V +1 12/15/21, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21128

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/15/21, 15:35

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 12/15/21, 17:20

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/15/21, 17:21

  6. Christian Kuhn merged patch set 2 12/15/21, 17:21