Review main Merged

72664[TASK] Simplify ext:belog "max" drop down code

Christian Kuhn CR +2 V +2 Normal +18 −115 updated 12/15/21, 21:47

Commit message

The "max" drop down in the ext:belog filter html
is the only one that uses belog:form.translateLabelSelect
view helper.
By refactoring slightly, we can drop this view
helper and simplify the code a bit.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 57

  1. Christian Kuhn uploaded patch set 1 12/15/21, 16:19

  2. core-ci voted on patch set 1 V -1 12/15/21, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21139

  3. Christian Kuhn uploaded patch set 2 12/15/21, 16:45

  4. core-ci voted on patch set 2 V +1 12/15/21, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21140

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/15/21, 17:18

  6. Georg Ringer voted on patch set 2 V +2 CR +2 12/15/21, 21:47

  7. Georg Ringer merged patch set 3 12/15/21, 21:47