Review main Merged

72665[TASK] Avoid extending view helpers in ext:extensionmanager

Christian Kuhn CR +2 V +2 Normal +32 −23 updated 12/16/21, 10:51

Commit message

ext:extensionmanager has a couple of view helpers that
extend ActionViewHelper for no apparent reason. Change
those to extend AbstractTagBasedViewHelper instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1316

  1. Christian Kuhn uploaded patch set 1 12/15/21, 17:59

  2. Christian Kuhn updated the commit message in patch set 2 12/15/21, 18:02

  3. core-ci voted on patch set 1 V +1 12/15/21, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21142

  4. core-ci voted on patch set 2 V +1 12/15/21, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21143

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 12/15/21, 22:57

  6. Benni Mack voted on patch set 2 V +1 CR +1 12/16/21, 07:35

  7. Benni Mack commented on patch set 2 12/16/21, 07:36

    I think we should backport this to 11.5 for a) people looking into core on how to build VHs b) conistency. This looks much faster (did not compare yet)
  8. Christian Kuhn commented on patch set 2 12/16/21, 08:15

    I'd actually skip a backport in this very case: There is codewise no reason to do so, these are details-VH's and we had the 'vh's will be final in v12 .rst' in v11 already. Speedwise there is very likely close to zero difference (basically one class less loaded and a couple of registerArgument calls less, that's nothing).
  9. Christian Kuhn commented on patch set 2 12/16/21, 08:15

    Reply

    but i also don't insist on it ... and well, i don't care too much, so yeah ... let's backport ...
  10. Christian Kuhn updated the commit message in patch set 3 12/16/21, 08:16

  11. Stefan Bürk voted on patch set 3 V +1 CR +1 12/16/21, 08:21

  12. Benni Mack voted on patch set 3 V +1 CR +1 12/16/21, 08:23

  13. core-ci voted on patch set 3 V +1 12/16/21, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21166

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 12/16/21, 10:03

  15. Christian Kuhn voted on patch set 3 V +2 CR +2 12/16/21, 10:51

  16. Christian Kuhn merged patch set 4 12/16/21, 10:51