7267[BUGFIX] Reports module shows unnecessary info text
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Files 1
Review log 22
-
Markus Klein uploaded patch set 2 01/28/12, 17:23
-
Markus Klein commented on patch set 2 01/28/12, 17:23
Thanks Oliver for pointing this out. The whole file was full of this, that's why I chose to stay with this syntax. I corrected it now everywhere, and even some more CGL. -
Markus Klein uploaded patch set 3 01/28/12, 17:23
-
Markus Klein uploaded patch set 4 01/28/12, 17:23
-
Markus Klein commented on patch set 4 01/28/12, 17:23
Previous patches failed in certain cases. -
Markus Klein uploaded patch set 5 01/28/12, 17:23
-
Markus Klein uploaded patch set 6 01/28/12, 17:23
-
Oliver Klee commented on patch set 1 01/28/12, 17:23
(1 inline comment)class.tx_reports_reports_status_securitystatus.php:298As per the CGL, the concatenation dot needs to be at the end of the line, not at the beginning. -
Oliver Klee commented on patch set 6 01/28/12, 17:23
Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 7 01/28/12, 17:23
-
Christian Kuhn commented on patch set 7 V 0 01/28/12, 17:23
by team member; Looks good to me, approved Merged. @Markus: I was not too happy with all your CGL changes in this file, it was hard to find the real change ... in the future a bigger cgl fix should be a separated patch. Anyway, the change itself is ok ('git diff -w' helped a bit), I just added the {} around your if ... if we do so much CGL in the patch we do not want to introduce new issues ;) Thanks for patch and reviews. Since reviews where already completed before and I just added another cgl thing ... I went ahead and merged this one. -
Philipp Gampe commented on patch set 6 01/28/12, 17:23
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 6 01/28/12, 17:23
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 01/28/12, 17:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2749/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/28/12, 17:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2766/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/28/12, 17:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2778/ : SUCCESS -
Mr. Jenkins commented on patch set 4 01/28/12, 17:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2779/ : SUCCESS -
Mr. Jenkins commented on patch set 5 01/28/12, 17:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2780/ : SUCCESS -
Mr. Jenkins commented on patch set 6 01/28/12, 17:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2782/ : SUCCESS -
Mr. Jenkins commented on patch set 7 01/28/12, 17:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3048/ : SUCCESS -
Wouter Wolters commented on patch set 6 01/28/12, 17:23
Verified; Looks good to me, but someone else must approve -
Christian Kuhn merged patch set 7 01/28/12, 17:23