Review main Merged

7267[BUGFIX] Reports module shows unnecessary info text

Markus Klein CR +2 V +2 Normal +71 −85 updated 06/03/13, 20:49

Commit message

Do not show saltedpasswords info text in reports module
unless problems have been detected.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 22

  1. Markus Klein uploaded patch set 2 01/28/12, 17:23

  2. Markus Klein commented on patch set 2 01/28/12, 17:23

    Thanks Oliver for pointing this out. The whole file was full of this, that's why I chose to stay with this syntax. I corrected it now everywhere, and even some more CGL.
  3. Markus Klein uploaded patch set 3 01/28/12, 17:23

  4. Markus Klein uploaded patch set 4 01/28/12, 17:23

  5. Markus Klein commented on patch set 4 01/28/12, 17:23

    Previous patches failed in certain cases.
  6. Markus Klein uploaded patch set 5 01/28/12, 17:23

  7. Markus Klein uploaded patch set 6 01/28/12, 17:23

  8. Oliver Klee commented on patch set 1 01/28/12, 17:23

    (1 inline comment)

    class.tx_reports_reports_status_securitystatus.php:298

    As per the CGL, the concatenation dot needs to be at the end of the line, not at the beginning.
  9. Oliver Klee commented on patch set 6 01/28/12, 17:23

    Looks good to me, but someone else must approve
  10. Christian Kuhn uploaded patch set 7 01/28/12, 17:23

  11. Christian Kuhn commented on patch set 7 V 0 01/28/12, 17:23

    by team member; Looks good to me, approved Merged. @Markus: I was not too happy with all your CGL changes in this file, it was hard to find the real change ... in the future a bigger cgl fix should be a separated patch. Anyway, the change itself is ok ('git diff -w' helped a bit), I just added the {} around your if ... if we do so much CGL in the patch we do not want to introduce new issues ;) Thanks for patch and reviews. Since reviews where already completed before and I just added another cgl thing ... I went ahead and merged this one.
  12. Philipp Gampe commented on patch set 6 01/28/12, 17:23

    Verified; Looks good to me, but someone else must approve
  13. Felix Kopp commented on patch set 6 01/28/12, 17:23

    Verified; Looks good to me, but someone else must approve
  14. Mr. Jenkins commented on patch set 1 01/28/12, 17:23

  15. Mr. Jenkins commented on patch set 2 01/28/12, 17:23

  16. Mr. Jenkins commented on patch set 3 01/28/12, 17:23

  17. Mr. Jenkins commented on patch set 4 01/28/12, 17:23

  18. Mr. Jenkins commented on patch set 5 01/28/12, 17:23

  19. Mr. Jenkins commented on patch set 6 01/28/12, 17:23

  20. Mr. Jenkins commented on patch set 7 01/28/12, 17:23

  21. Wouter Wolters commented on patch set 6 01/28/12, 17:23

    Verified; Looks good to me, but someone else must approve
  22. Christian Kuhn merged patch set 7 01/28/12, 17:23