Review main Merged

72670[FOLLOWUP] Add setContext() to ProviderInterface

Oli Bartsch CR +2 V +2 Easy +16 −3 updated 12/16/21, 11:47

Commit message

The new `setContext` method is added to the
ProviderInterface, making the API more robust.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Oli Bartsch uploaded patch set 1 12/16/21, 10:58

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 12/16/21, 11:02

  3. Oli Bartsch uploaded patch set 2 12/16/21, 11:03

  4. Christian Kuhn updated the commit message in patch set 3 12/16/21, 11:11

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 12/16/21, 11:11

  6. core-ci voted on patch set 1 V +1 12/16/21, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21171

  7. core-ci voted on patch set 2 V +1 12/16/21, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21172

  8. core-ci voted on patch set 3 V +1 12/16/21, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21173

  9. Benni Mack voted on patch set 3 V +1 CR +1 12/16/21, 11:46

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 12/16/21, 11:47

  11. Oli Bartsch merged patch set 4 12/16/21, 11:47