Review main Merged Breaking

72671[!!!][TASK] Declare all ViewHelpers final

Christian Kuhn CR +2 V +2 Hard +206 −258 updated 12/17/21, 09:14

Commit message

As anticipated in v11 with #95298, this patch
declares ViewHelper classes PHP final, third party
extensions can no longer extend core ViewHelpers.

There is one exception: The ext:fluid FormViewHelper,
which is currently extended by ext:form. This can't
be resolved easily since it's on one hand quite a bit
of code that would have to be copied, and more importantly,
the FormField* ViewHelpers refer to the "parent"
FormViewHelper class name in various places. Declaring
FormViewHelper final thus needs a different refactoring,
which may be done in v12 with further patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 132

Show 112 more files

Review log 1012

  1. Christian Kuhn uploaded patch set 1 12/16/21, 12:06

  2. Christian Kuhn voted on patch set 1 CR -1 12/16/21, 12:07

  3. Christian Kuhn uploaded patch set 2 12/16/21, 12:14

  4. core-ci voted on patch set 1 V +1 12/16/21, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21174

  5. core-ci voted on patch set 2 V +1 12/16/21, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21175

  6. Stefan Bürk commented on patch set 2 12/16/21, 12:48

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:53

    Not correct, or ? Should state the "except ext:fluid FormViewHelper ..." in it.
  7. Christian Kuhn commented on patch set 2 12/16/21, 12:57

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:53 Reply

    i'd actually skip that info here ... first, we may refactor that VH a bit to come up with making it final later. and secondly, formVH is probably not one of those that is frequently extended (it's extbase specific, it's complex, you probably don't want to mess around with it in extensions if you don't know exactly what you're doing).
  8. Stefan Bürk commented on patch set 2 V +1 CR +1 12/16/21, 13:06

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:53 Reply

    Ack.
  9. Oli Bartsch voted on patch set 2 CR +1 12/16/21, 14:24

  10. Benni Mack voted on patch set 2 V +1 CR +1 12/16/21, 16:25

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 12/17/21, 09:14

  12. Christian Kuhn merged patch set 3 12/17/21, 09:14