72671[!!!][TASK] Declare all ViewHelpers final
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 132
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php+1 −1
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Mfa/IfHasStateViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ArrayBrowserViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/LanguageColumnViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ThumbnailViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/Display/TableAccessViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/MfaStatusViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+1 −1
Show 112 more files
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96107-DeprecatedFunctionalityRemoved.rst3+3 −0
- typo3/sysext/dashboard/Classes/ViewHelpers/Widget/ButtonViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Be/TriggerViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ConstraintsViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/InstallationStateCssClassViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ProcessAvailableActionsViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/CshViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Labels/CshViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php+10 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfHasRoleViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/LinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/UriViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptgroupViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CurrencyViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/JsonViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/Nl2brViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/NumberViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ExternalViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Sanitize/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfHasRoleViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Transform/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ExternalViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/DebugViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/RenderViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/TypolinkViewHelperTest.php+6 −11
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/TypolinkViewHelperTest.php+10 −8
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Be/MaximumFileSizeViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Form/TimePickerViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Form/UploadedResourceViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/GridColumnClassAutoConfigurationViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+1 −1
- typo3/sysext/form/Tests/Unit/ViewHelpers/Form/DatePickerViewHelperTest.php+50 −111
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/DateTimeViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/GroupListViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingResultsViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/Format/NoSpaceViewHelper.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/Format/PhpErrorCodeViewHelper.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/Uri/ActionViewHelper.php+1 −1
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+1 −1
- typo3/sysext/redirects/Classes/ViewHelpers/TargetPageIdViewHelper.php+1 −1
Review log 1012
-
Christian Kuhn uploaded patch set 1 12/16/21, 12:06
-
Christian Kuhn voted on patch set 1 CR -1 12/16/21, 12:07
-
Christian Kuhn uploaded patch set 2 12/16/21, 12:14
-
core-ci voted on patch set 1 V +1 12/16/21, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21174
-
core-ci voted on patch set 2 V +1 12/16/21, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21175
-
Stefan Bürk commented on patch set 2 12/16/21, 12:48
-
Christian Kuhn commented on patch set 2 12/16/21, 12:57
Breaking-96107-DeprecatedFunctionalityRemoved.rst:53Replyi'd actually skip that info here ... first, we may refactor that VH a bit to come up with making it final later. and secondly, formVH is probably not one of those that is frequently extended (it's extbase specific, it's complex, you probably don't want to mess around with it in extensions if you don't know exactly what you're doing). -
Stefan Bürk commented on patch set 2 V +1 CR +1 12/16/21, 13:06
Breaking-96107-DeprecatedFunctionalityRemoved.rst:53ReplyAck. -
Oli Bartsch voted on patch set 2 CR +1 12/16/21, 14:24
-
Benni Mack voted on patch set 2 V +1 CR +1 12/16/21, 16:25
-
Christian Kuhn voted on patch set 2 V +2 CR +2 12/17/21, 09:14
-
Christian Kuhn merged patch set 3 12/17/21, 09:14
Breaking-96107-DeprecatedFunctionalityRemoved.rst:53