Review 11.5 Merged

72673[BUGFIX] Render hreflang only for translated pages

Benni Mack CR +2 V +2 Easy +20 −5 updated 12/15/21, 11:27

Commit message

If a language in the SiteConfig is set to the fallbackType
free and there is no translated page for this language, then
there is now no generated hreflang.

Previously, a link was always generated with default language
slug, which lead to 404 page not found.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Benni Mack commented on patch set 1 12/15/21, 07:31

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/15/21, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21115

  3. Stefan Bürk commented on patch set 1 V +1 CR +1 12/15/21, 10:18

    Reverified in v11 instance with patchset 1 checkout
  4. Benni Mack voted on patch set 1 V +2 CR +2 12/15/21, 11:27

  5. Benni Mack merged patch set 2 12/15/21, 11:27