Review 10.4 Merged

72692[BUGFIX] Avoid select and therefore fetchFirstColumn() of doctrine/dbal

Christian Kuhn CR +2 V +2 Easy +15 −26 updated 12/17/21, 15:25

Commit message

Get rid of the select query entirely, which optimises
the task to only require one update query instead of
one select and possibly multiple update queries and
gets rid of doctrine version related incompatibilities
with fetching the select result.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 1316

  1. Christian Kuhn uploaded patch set 1 12/16/21, 12:45

  2. core-ci voted on patch set 1 V +1 12/16/21, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21179

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 12/16/21, 13:08

  4. Helmut Hummel voted on patch set 1 CR -1 12/16/21, 13:16

  5. Helmut Hummel commented on patch set 1 12/16/21, 13:18

    MetaDataEventListener.php:51

    Can we fix this by changing the select + multiple update queries here to one atomic update query (in both main and 10.4 branch)?
  6. Helmut Hummel commented on patch set 1 12/16/21, 13:34

    Here is my suggestion to be merged in all branches: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72693
  7. Christian Kuhn commented on patch set 1 12/16/21, 13:38

    Thanks Helmut! Abandoning in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/72692
  8. Christian Kuhn abandoned the change 12/16/21, 13:38

  9. Helmut Hummel restored the change 12/17/21, 15:05

  10. Helmut Hummel uploaded patch set 2 12/17/21, 15:09

  11. Helmut Hummel uploaded patch set 3 12/17/21, 15:13

  12. Helmut Hummel commented on patch set 3 12/17/21, 15:14

    MetaDataEventListener.php:51 Reply

    Done
  13. core-ci voted on patch set 2 V +1 12/17/21, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21216

  14. Helmut Hummel voted on patch set 3 V +2 CR +2 12/17/21, 15:22

  15. core-ci voted on patch set 3 V +1 12/17/21, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21217

  16. Helmut Hummel merged patch set 4 12/17/21, 15:25