Review main Merged

72693[BUGFIX] Avoid select and therefore fetchFirstColumn() of doctrine/dbal

Helmut Hummel CR +2 V +2 Easy +13 −27 updated 12/17/21, 15:03

Commit message

Get rid of the select query entirely, which optimises
the task to only require one update query instead of
one select and possibly multiple update queries and
gets rid of doctrine version related incompatibilities
with fetching the select result.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Helmut Hummel uploaded patch set 1 12/16/21, 13:33

  2. Helmut Hummel uploaded patch set 2 12/16/21, 13:37

  3. Christian Kuhn commented on patch set 2 CR +1 12/16/21, 13:46

    Reads well, thanks! Maybe that's a good opportunity to add a class comment that says why this event is there and what it achieves?
  4. core-ci voted on patch set 1 V +1 12/16/21, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21183

  5. core-ci voted on patch set 2 V +1 12/16/21, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21184

  6. Oliver Klee voted on patch set 2 CR +1 12/17/21, 10:25

  7. Benni Mack voted on patch set 2 V +1 CR +1 12/17/21, 10:26

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 12/17/21, 14:11

  9. Helmut Hummel voted on patch set 2 V +2 CR +2 12/17/21, 15:03

  10. Helmut Hummel merged patch set 3 12/17/21, 15:03