Review main Merged

72701[FEATURE] Move linkvalidator reports to new module

Benni Mack CR +2 V +2 Expert +746 −717 updated 01/05/22, 21:35

Commit message

The linkvalidator backend module was previously
built into the Web->Info module.

Now, Linkvalidator receives its own module in the
"Web" area. This allows to define access permissions
for editors via the module access logic, and shapes
the functionality in a cleaner way.

The Linkvalidator module not only reports but also
allows to validate. Through this change, the module
is now accessible via a dedicated speaking backend URL.

This change makes the feature much more prominent
and allows for further refinements such as pagination.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1218

  1. Benni Mack uploaded patch set 1 12/17/21, 12:47

  2. core-ci voted on patch set 1 V -1 12/17/21, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21211

  3. Oli Bartsch rebased onto patch set 2 01/03/22, 15:14

  4. core-ci voted on patch set 2 V -1 01/03/22, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21567

  5. Oli Bartsch uploaded patch set 3 01/05/22, 00:14

  6. core-ci voted on patch set 3 V +1 01/05/22, 00:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21624

  7. Oli Bartsch uploaded patch set 4 01/05/22, 14:49

  8. core-ci voted on patch set 4 V +1 01/05/22, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21649

  9. Oli Bartsch uploaded patch set 5 01/05/22, 15:34

  10. core-ci voted on patch set 5 V +1 01/05/22, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21652

  11. Stefan Bürk commented on patch set 5 CR -1 01/05/22, 17:24

    on it
  12. Stefan Bürk commented on patch set 5 01/05/22, 17:52

    typo3/sysext/linkvalidator/Resources/Private/Templates/Backend/LinkvalidatorModule.html should be typo3/sysext/linkvalidator/Resources/Private/Templates/Backend/LinkValidatorModule.html Casing, failing on case-sensitive filesystems (linux).
  13. Stefan Bürk uploaded patch set 6 01/05/22, 17:52

  14. Stefan Bürk commented on patch set 6 CR +1 01/05/22, 17:53

    Reply

    Renamed.
  15. core-ci voted on patch set 6 V +1 01/05/22, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21662

  16. Stefan Bürk voted on patch set 6 V +1 01/05/22, 18:22

  17. Benni Mack voted on patch set 6 V +2 CR +2 01/05/22, 21:35

  18. Benni Mack merged patch set 7 01/05/22, 21:35