Review main Merged

72704[BUGFIX] Avoid exception in ContentObjectRenderer with PHP8

Torben Hansen CR +2 V +2 Easy +12 −1 updated 12/18/21, 12:54

Commit message

This patch ensures that the getQuery() function only uses the
minus operator to negate the $storagePid variable, if the variable
can be interpreted as an integer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Torben Hansen uploaded patch set 1 12/18/21, 06:47

  2. core-ci voted on patch set 1 V +1 12/18/21, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21228

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/18/21, 07:30

  4. Oliver Klee voted on patch set 1 CR +1 12/18/21, 09:51

  5. Nikita Hovratov uploaded patch set 2 12/18/21, 11:23

  6. Nikita Hovratov commented on patch set 2 V +1 CR +1 12/18/21, 11:25

    Added test case with pidInList=root
  7. core-ci voted on patch set 2 V +1 12/18/21, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21235

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/18/21, 12:54

  9. Benni Mack merged patch set 3 12/18/21, 12:54