72705[WIP][FEATURE] Allow HTML in EXT:form
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 29
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −2
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+24 −0
- typo3/sysext/form/Classes/Domain/Factory/AbstractFormFactory.php+6 −0
- typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php+1 −0
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/FormDefinitionArrayConverter.php+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Field.html+3 −3
- typo3/sysext/form/Resources/Private/Frontend/Partials/Form/Navigation.html+3 −3
- typo3/sysext/form/Resources/Private/Frontend/Partials/AdvancedPassword.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Checkbox.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/DatePicker.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Fieldset.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/MultiCheckbox.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Page.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/RadioButton.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/StaticText.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/SummaryPage.html+3 −3
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Confirmation/Confirmation.html+1 −8
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.html+2 −2
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/Field/Field.html+4 −4
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/Form/Navigation.html+3 −3
Show 9 more files
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/AdvancedPassword.html+4 −4
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/Checkbox.html+1 −1
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/DatePicker.html+2 −2
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/Fieldset.html+1 −1
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/MultiCheckbox.html+2 −2
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/Page.html+1 −1
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/RadioButton.html+2 −2
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/StaticText.html+2 −2
- typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/SummaryPage.html+3 −3
Review log 1523
-
Benni Mack uploaded patch set 1 12/18/21, 08:22
-
core-ci voted on patch set 1 V +1 12/18/21, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21232
-
Benni Mack commented on patch set 2 01/25/22, 19:22
Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 01/25/22, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22543
-
Gabe Troyan uploaded patch set 3 02/02/22, 18:50
-
core-ci voted on patch set 3 V +1 02/02/22, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22917
-
Benni Mack updated the commit message in patch set 4 02/14/22, 16:32
-
core-ci voted on patch set 4 V +1 02/14/22, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23533
-
Benjamin Franzke rebased onto patch set 5 02/19/22, 21:01
-
core-ci voted on patch set 5 V +1 02/19/22, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23910
-
Björn Jacob commented on patch set 5 02/25/22, 19:51
Hi Benni. How do you want to proceed with this patch? -
waldhacker marked it work in progress 02/26/22, 15:17
-
Benni Mack commented on patch set 5 02/28/22, 10:31
Reply
Hey, personally, I don't know if this is the correct way to implement it into EXT:form, that's why I sent it to the Ralf and the Form initiative in Dec for review and further decisions (what template parts should allow HTML, if the sanitzer build should be configurable, and if yes, in what place). So I'm happy to proceed, but I'm also happy if somebody else would pick it up. -
waldhacker uploaded patch set 6 06/29/22, 17:05
-
core-ci voted on patch set 6 V +1 06/29/22, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28509
-
Oliver Hader commented on patch set 6 06/30/22, 08:43
General remark... instead of using `f:format.raw` I'd probably use the `f:sanitize.html -> f:transform.html` chain in Fluid templates. -
waldhacker commented on patch set 6 06/30/22, 08:52
This change is ready for review.Reply Unresolved
ACK -
waldhacker marked it work in progress 06/30/22, 08:53
-
waldhacker uploaded patch set 7 06/30/22, 09:05
-
core-ci voted on patch set 7 V +1 06/30/22, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28521
-
Benni Mack uploaded patch set 8
V +101/24/23, 13:52 -
core-ci voted on patch set 8 V +1 01/24/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36545
-
Benni Mack abandoned the change 02/10/23, 08:02
will abandon this for the lack of feedback