Review main Merged

72706[TASK] Use database cache backend for specific tests

Stefan Bürk CR +2 V +2 Normal +53 −4 updated 12/19/21, 19:33

Commit message

With a recent change in typo3/testing-framework,
various core caches in functional tests are set
to NullBackend. This speeds up functional tests
up to 10% since the table creation and insert
load is higher in testing scenarios than actual
cache hit benefits.

Some functional tests however work on those tables,
for instance the functional test of the database
cache backend. The patch adapts these tests to
according LocalConfiguration setup.

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Gilli +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1116

  1. Stefan Bürk uploaded patch set 1 12/18/21, 20:50

  2. Stefan Bürk uploaded patch set 2 12/18/21, 20:57

  3. core-ci voted on patch set 1 V +1 12/18/21, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21241

  4. Stefan Bürk updated the commit message in patch set 3 12/18/21, 21:07

  5. core-ci voted on patch set 2 V +1 12/18/21, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21242

  6. core-ci voted on patch set 3 V +1 12/18/21, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21243

  7. Christian Kuhn marked it ready for review 12/19/21, 10:34

  8. Christian Kuhn uploaded patch set 4 12/19/21, 10:43

  9. core-ci voted on patch set 4 V +1 12/19/21, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21253

  10. Oliver Klee voted on patch set 4 CR +1 12/19/21, 11:24

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 12/19/21, 12:59

  12. Stefan Bürk commented on patch set 4 12/19/21, 15:38

  13. core-ci commented on patch set 4 12/19/21, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21254

  14. Simon Gilli voted on patch set 4 V +1 CR +1 12/19/21, 19:27

  15. Benni Mack voted on patch set 4 V +2 CR +2 12/19/21, 19:33

  16. Benni Mack merged patch set 5 12/19/21, 19:33