Review main Merged

72709[TASK] Replace placeholders in phpstan configuration

Sybille Peters CR +2 V +2 Easy +9 −9 updated 12/20/21, 20:27

Commit message

The phpstan configuration documentation recommends to specify the
paths relative to the directory of the configuration file.

Thus using, currentWorkingDirectory (as current working directory)
is unnecessary and removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Sybille Peters uploaded patch set 1 12/19/21, 01:03

  2. core-ci voted on patch set 1 V +1 12/19/21, 01:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21248

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/20/21, 16:12

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 12/20/21, 19:18

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/20/21, 20:27

  6. Christian Kuhn merged patch set 2 12/20/21, 20:27