Review main Merged

72710[TASK] Avoid deprecated doctrine/dbal method 'executeUpdate()'

Stefan Bürk CR +2 V +2 Easy +7 −7 updated 12/20/21, 09:14

Commit message

doctrine/dbal deprecated quite some methods to cleanup
their codebase and provided replacements with more
speaking method names.

Most depcrecated method usages have been replaced in
the core, but we missed some.

The patch replaces the depcrecated method 'executeUpdate()'
with the corresponding 'executeStatement()' method in
several places to cleanup this up.

This can be done also in 11.5 too, the required minimum
version of doctrine/dbal provides these new methods as
upwards compatible layer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1317

  1. Stefan Bürk uploaded patch set 1 12/19/21, 19:21

  2. Stefan Bürk updated the commit message in patch set 2 12/19/21, 19:23

  3. core-ci voted on patch set 1 V -1 12/19/21, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21256

  4. Benni Mack voted on patch set 2 V +1 CR +1 12/19/21, 19:35

  5. Stefan Bürk wrote 12/19/21, 19:41

    Removed Code-Review+1 by Benni Mack <benni@typo3.org>
  6. Stefan Bürk wrote 12/19/21, 19:41

    Removed Verified+1 by Benni Mack <benni@typo3.org>
  7. core-ci voted on patch set 2 V -1 12/19/21, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21257

  8. Stefan Bürk uploaded patch set 3 12/19/21, 19:47

  9. core-ci voted on patch set 3 V +1 12/19/21, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21258

  10. Benni Mack voted on patch set 3 CR +1 12/19/21, 20:29

  11. Simon Gilli voted on patch set 3 CR +1 12/19/21, 20:51

  12. Benni Mack voted on patch set 3 V +1 12/20/21, 08:12

  13. Christian Kuhn uploaded patch set 4 12/20/21, 08:49

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 12/20/21, 08:50

  15. core-ci voted on patch set 4 V +1 12/20/21, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21266

  16. Benni Mack voted on patch set 4 V +2 CR +2 12/20/21, 09:14

  17. Benni Mack merged patch set 5 12/20/21, 09:14