Review 11.5 Merged

72712[BUGFIX] Fix PHP 8 strict warning in Package MetaData

Helmut Hummel CR +2 V +2 Normal +73 −7 updated 12/18/21, 15:12

Commit message

A "type" does not need to be set in a composer.json,
so the checks for package type must account for the type
being null, to not trigger a warning in PHP 8

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Helmut Hummel commented on patch set 1 12/17/21, 15:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/17/21, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21219

  3. Oliver Klee voted on patch set 1 CR +1 12/17/21, 16:25

  4. Helmut Hummel voted on patch set 1 V +2 CR +2 12/18/21, 15:11

  5. Helmut Hummel merged patch set 2 12/18/21, 15:12