Review main Merged

72735[BUGFIX] Fix scoping issue in FormEngineValidation

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 12/20/21, 14:37

Commit message

theChar is not initialized and therefore pollutes global scope.
(It is assigned to window.theChar in the FormEngine iframe).

Currently not an error (we are not using strict mode in RequireJS),
just bad style, but once we switch to strict mode (type="module"),
this will fail without proper declaration.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Benjamin Franzke uploaded patch set 1 12/20/21, 12:39

  2. Benni Mack commented on patch set 1 12/20/21, 12:44

    Please declare as bugfix (scoping issue), and also bring it back to 11.5
  3. core-ci voted on patch set 1 V +1 12/20/21, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21278

  4. Benjamin Franzke updated the commit message in patch set 2 12/20/21, 13:11

  5. Benjamin Franzke commented on patch set 2 12/20/21, 13:11

    Reply

    Ack, we should do so. Done.
  6. core-ci voted on patch set 2 V +1 12/20/21, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21281

  7. Christian Kuhn voted on patch set 2 CR +1 12/20/21, 13:43

  8. Benni Mack commented on patch set 2 V +1 CR +1 12/20/21, 13:54

    please merge
  9. Andreas Kienast voted on patch set 2 V +2 CR +2 12/20/21, 14:37

  10. Andreas Kienast merged patch set 3 12/20/21, 14:37