Review main Merged

72736[TASK] Prepare ImmediateActionElementTest for ES6 modules

Benjamin Franzke CR +2 V +2 Normal +32 −28 updated 12/20/21, 20:58

Commit message

In ES6 mode Viewport.Topbar and ModuleMenu.App properties
cannot be overwritten (in order to be substituted with a call spy),
as they reference other JavaScript modules.
The properties of ES6 models are readonly ("frozen") and can
therefore not be overwritten in a test setup.

Therefore the test is adapted to overwrite the references
in Viewport and ModuleMenu instead.

Also a timeout is added as await import('TYPO3/CMS/Backend/ModuleMenu')
does not guarantee a loading order between modules in ES6, which
causes test asserts to be executed too early.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Benjamin Franzke uploaded patch set 1 12/20/21, 12:55

  2. core-ci voted on patch set 1 V +1 12/20/21, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21279

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/20/21, 16:12

  4. Benjamin Franzke commented on patch set 1 V +2 CR +2 12/20/21, 20:58

    Merging, as this is just a testing fix, one missing vote should be fine.
  5. Benjamin Franzke merged patch set 2 12/20/21, 20:58