Review main Abandoned

72737[BUGFIX] Allow import of relative paths in PageTsConfig

Jochen Roth CR 0 V 0 Easy +17 −10 updated 07/12/22, 17:45

Commit message

Currently relative paths in pageTsconfig added using
registerPageTSConfigFile() are not respected.

This has been fixed by doing a checkIncludeLines()
on each 'tsconfig_includes'.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 914

  1. Jochen Roth uploaded patch set 1 12/20/21, 12:58

  2. Jochen Roth marked it work in progress 12/20/21, 12:58

  3. core-ci voted on patch set 1 V +1 12/20/21, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21280

  4. Jochen Roth uploaded patch set 2 12/20/21, 15:22

  5. core-ci voted on patch set 2 V +1 12/20/21, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21299

  6. Jochen Roth commented on patch set 2 12/20/21, 15:43

    PageTsConfigLoader.php:109

    Not sure if we should drop this, and let developers using ModifyLoadedPageTsConfigEvent() handle relative includes themselves.
  7. Jochen Roth uploaded patch set 3 12/22/21, 09:40

  8. core-ci voted on patch set 3 V -1 12/22/21, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21386

  9. Jochen Roth uploaded patch set 4 12/22/21, 09:54

  10. core-ci voted on patch set 4 V -1 12/22/21, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21388

  11. Jochen Roth uploaded patch set 5 12/22/21, 10:34

  12. core-ci voted on patch set 5 V -1 12/22/21, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21391

  13. Benni Mack commented on patch set 5 01/21/22, 20:38

    PageTsConfigLoader.php:109 Reply Unresolved

    I recommend using checkIncludeLines() directly
  14. Jochen Roth abandoned the change 07/12/22, 17:45