Review main Merged

72738[BUGFIX] Allow CSV in startingPoints config as advertised

Andreas Kienast CR +2 V +2 Easy +24 −4 updated 12/21/21, 12:06

Commit message

The category starting points introduced with #95037 were designed to
allow comma-separated values in its configuration. Due to improper
tests, this specific notation was not discovered as being broken right
now.

If the incoming configuration is a string, GeneralUtility::intExplode()
is applied to remove any non-integer value. Afterwards, a new CSV
string is generated.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 12/20/21, 14:12

  2. core-ci voted on patch set 1 V +1 12/20/21, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21287

  3. Benni Mack voted on patch set 1 CR +1 12/20/21, 14:25

  4. Oli Bartsch uploaded patch set 2 12/20/21, 23:12

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 12/20/21, 23:14

  6. core-ci voted on patch set 2 V +1 12/20/21, 23:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21324

  7. Benni Mack voted on patch set 2 V +1 CR +1 12/21/21, 11:07

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 12/21/21, 12:05

  9. Andreas Kienast merged patch set 3 12/21/21, 12:06