Review main Merged

72739[TASK] Raise friendsofphp/php-cs-fixer:^3.4

Stefan Bürk CR +2 V +2 Easy +23 −24 updated 12/20/21, 16:05

Commit message

The dev dependency friendsofphp/php-cs-fixer now
has a minimum requirement to 3.4, which comes
with PHP8.1 support.

This allows TYPO3 to run PHP-CS Fixer with
PHP 8.1 in the CI pipeline.

Testing configuration is not adjusted with this
patch, but allows using corresponding runTests.sh
testsuites cgl and cglGit:

Build/Scripts/runTests.sh -p 8.1 -s cglGit -n
Build/Scripts/runTests.sh -p 8.1 -s cgl -n

Used command:

composer req friendsofphp/php-cs-fixer:^3.4 --dev

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Stefan Bürk uploaded patch set 1 12/20/21, 14:27

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 12/20/21, 14:35

  3. core-ci voted on patch set 1 V +1 12/20/21, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21289

  4. Benni Mack updated the commit message in patch set 2 12/20/21, 15:48

  5. core-ci voted on patch set 2 V +1 12/20/21, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21301

  6. Benni Mack voted on patch set 2 V +2 CR +2 12/20/21, 16:05

  7. Benni Mack merged patch set 3 12/20/21, 16:05