72741[TASK] Modernize ViewHelper classes
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 115
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php+3 −12
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php+4 −14
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+4 −3
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php+5 −4
- typo3/sysext/backend/Classes/ViewHelpers/Mfa/IfHasStateViewHelper.php+0 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php+4 −7
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php+5 −8
- typo3/sysext/backend/Classes/ViewHelpers/ArrayBrowserViewHelper.php+4 −13
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+4 −10
- typo3/sysext/backend/Classes/ViewHelpers/LanguageColumnViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+1 −10
- typo3/sysext/backend/Classes/ViewHelpers/ThumbnailViewHelper.php+5 −6
- typo3/sysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.php+7 −16
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+7 −17
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php+10 −14
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php+20 −30
- typo3/sysext/beuser/Classes/ViewHelpers/Display/TableAccessViewHelper.php+4 −1
- typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php+6 −10
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+18 −26
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+8 −19
Show 95 more files
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+13 −14
- typo3/sysext/core/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+6 −56
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php+5 −13
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php+2 −11
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php+6 −12
- typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php+6 −14
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Be/TriggerViewHelper.php+4 −7
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ConstraintsViewHelper.php+2 −9
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+31 −69
- typo3/sysext/extensionmanager/Classes/ViewHelpers/InstallationStateCssClassViewHelper.php+6 −13
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ProcessAvailableActionsViewHelper.php+8 −15
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+15 −11
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+15 −11
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+15 −13
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php+3 −15
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerShowVersionsTable.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerTable.html+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php+2 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php+2 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php+7 −21
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfAuthenticatedViewHelper.php+3 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfHasRoleViewHelper.php+5 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+4 −14
- typo3/sysext/fluid/Classes/ViewHelpers/Be/LinkViewHelper.php+5 −15
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+7 −20
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+10 −26
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+22 −32
- typo3/sysext/fluid/Classes/ViewHelpers/Be/UriViewHelper.php+4 −13
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.php+10 −17
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptgroupViewHelper.php+4 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.php+4 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php+4 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php+4 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php+5 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php+4 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php+4 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+20 −31
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php+4 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php+5 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php+6 −14
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadViewHelper.php+4 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+4 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Format/AbstractEncodingViewHelper.php+4 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+6 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+4 −16
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CurrencyViewHelper.php+4 −16
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+4 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php+4 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php+3 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+16 −29
- typo3/sysext/fluid/Classes/ViewHelpers/Format/JsonViewHelper.php+4 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Format/Nl2brViewHelper.php+5 −16
- typo3/sysext/fluid/Classes/ViewHelpers/Format/NumberViewHelper.php+6 −17
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php+6 −14
- typo3/sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.php+9 −19
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.php+4 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+4 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ExternalViewHelper.php+4 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+8 −22
- typo3/sysext/fluid/Classes/ViewHelpers/Sanitize/HtmlViewHelper.php+6 −17
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfAuthenticatedViewHelper.php+3 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfHasRoleViewHelper.php+4 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Transform/HtmlViewHelper.php+4 −21
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ExternalViewHelper.php+4 −15
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+5 −15
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+7 −18
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php2+16 −32
- typo3/sysext/fluid/Classes/ViewHelpers/DebugViewHelper.php+14 −14
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+10 −9
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+13 −15
- typo3/sysext/fluid/Classes/ViewHelpers/RenderViewHelper.php+3 −1
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php+8 −22
- typo3/sysext/form/Classes/ViewHelpers/Be/MaximumFileSizeViewHelper.php+1 −8
- typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php+2 −14
- typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php+5 −23
- typo3/sysext/form/Classes/ViewHelpers/Form/TimePickerViewHelper.php+5 −32
- typo3/sysext/form/Classes/ViewHelpers/Form/UploadedResourceViewHelper.php+5 −30
- typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php+2 −10
- typo3/sysext/form/Classes/ViewHelpers/GridColumnClassAutoConfigurationViewHelper.php+3 −17
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+2 −12
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+13 −37
- typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php+2 −15
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+4 −15
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+2 −15
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+2 −10
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/DateTimeViewHelper.php+5 −10
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php+4 −12
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/GroupListViewHelper.php+5 −13
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingResultsViewHelper.php+6 −12
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php+7 −12
- typo3/sysext/install/Classes/ViewHelpers/Format/NoSpaceViewHelper.php+1 −10
- typo3/sysext/install/Classes/ViewHelpers/Format/PhpErrorCodeViewHelper.php+6 −16
- typo3/sysext/install/Classes/ViewHelpers/Uri/ActionViewHelper.php+5 −11
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+14 −30
- typo3/sysext/redirects/Classes/ViewHelpers/TargetPageIdViewHelper.php+2 −4
Review log 1420
-
Christian Kuhn uploaded patch set 1 12/20/21, 14:38
-
Christian Kuhn uploaded patch set 2 12/20/21, 14:41
-
core-ci voted on patch set 1 V +1 12/20/21, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21293
-
core-ci voted on patch set 2 V +1 12/20/21, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21294
-
Christian Kuhn uploaded patch set 3 12/20/21, 15:11
-
core-ci voted on patch set 3 V +1 12/20/21, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21298
-
Andreas Kienast commented on patch set 3 CR -1 12/20/21, 16:18
on itCObjectViewHelper.php:238: void -
Andreas Kienast uploaded patch set 4 12/20/21, 16:35
-
Christian Kuhn commented on patch set 4 12/20/21, 16:36
CObjectViewHelper.php:238ReplyDone -
core-ci voted on patch set 4 V +1 12/20/21, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21311
-
Andreas Kienast commented on patch set 4 V +1 CR +1 12/20/21, 16:51
Clicking around didn't break anything so far. -
Christian Kuhn commented on patch set 4 CR -1 12/20/21, 16:51
i'll review in detail again - especially argument casting needs to be ok with VH's where we added strict_types=1 to prevent regressions. -
Christian Kuhn uploaded patch set 5 12/20/21, 19:57
-
core-ci voted on patch set 5 V -1 12/20/21, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21315
-
Christian Kuhn uploaded patch set 6 12/20/21, 20:00
-
Stefan Bürk voted on patch set 6 V +1 CR +1 12/20/21, 20:19
-
Andreas Kienast voted on patch set 6 V +1 CR +1 12/20/21, 20:20
-
core-ci voted on patch set 6 V +1 12/20/21, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21316
-
Christian Kuhn voted on patch set 6 V +2 CR +2 12/20/21, 20:22
-
Christian Kuhn merged patch set 7 12/20/21, 20:22