Review main Abandoned

72745[WIP][TASK] Adapt FileClipboardCest for asychronous behaviour

Benjamin Franzke CR 0 V 0 Easy +1 −0 updated 12/21/21, 07:39

Commit message

The triggered label-click causes a page (iframe) reload,
in order to show an adapted clipboard panel.

Wait some seconds to ensure the iframe as been reloaded.

Note: This has been discovered using ES6 type modules
instead of AMD modules and RequireJS (see #96323).

TODO:
 * Why didn't this fail with RequireJS?

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke uploaded patch set 1 12/20/21, 16:03

  2. core-ci voted on patch set 1 V +1 12/20/21, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21305

  3. Benjamin Franzke commented on patch set 1 CR -2 12/20/21, 16:23

    Unresolved

    Likely due to the global "wait: 1" option… https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Tests/Acceptance/Application.suite.yml#L7 So I'll try to optimize (importmap caching) ES6 loading, hope that'll help here.
  4. Benjamin Franzke abandoned the change 12/21/21, 07:39

    Test with ES6 were too slow (exceeding default 1s waiting time). Avoiding a polyfill (that caused a slow startup) when importmaps are supported, fixes this issue.