Review main Merged

72747[TASK] Cleanup ext:viewpage template

Christian Kuhn CR +2 V +2 Easy +5 −6 updated 12/20/21, 17:08

Commit message

There is no point in having the main template in
a sub folder, move it up. Additionally use full
EXT: syntax for f:translate arguments and avoid
a useless flashMessage VH call that is already
done by ModuleTemplate automatically.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/20/21, 16:20

  2. core-ci voted on patch set 1 V +1 12/20/21, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21309

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 12/20/21, 16:39

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 12/20/21, 17:08

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/20/21, 17:08

  6. Christian Kuhn merged patch set 2 12/20/21, 17:08