Review main Merged

72749[BUGFIX] Fix doctype annotations

Simon Schaufelberger CR +2 V +2 Easy +6 −6 updated 12/21/21, 11:08

Commit message

According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types
it is only allowed to use "string|null" and not "?string"

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 67

  1. Simon Schaufelberger uploaded patch set 1 12/20/21, 22:03

  2. core-ci voted on patch set 1 V +1 12/20/21, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21320

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 12/21/21, 09:52

  4. Benni Mack voted on patch set 1 V +1 CR +1 12/21/21, 10:07

  5. Oliver Klee voted on patch set 1 CR +1 12/21/21, 10:22

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 12/21/21, 11:08

  7. Christian Kuhn merged patch set 2 12/21/21, 11:08