Review main Merged

72752[BUGFIX] Remove failing and superflous test for QueryHelper

Stefan Bürk CR +2 V +2 Easy +1 −37 updated 12/21/21, 08:06

Commit message

With #96393 forward-compatible prepared statement
support has been added to QueryBuilder and also
provided several tests to covers this implementation.

However one test tests doctrine/dbal behaviour for
'Statement->bindValue()' which behaves differently
accross drivers and platforms, emitting different
exception types or need an additional execute.

This patch removes this test as it is not the job
of core testing to test 3rd party code and inconsistent
behaviour.

Removed test were already removed on backport for #96393.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Stefan Bürk uploaded patch set 1 12/21/21, 06:03

  2. core-ci voted on patch set 1 V +1 12/21/21, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21328

  3. Stefan Bürk commented on patch set 1 12/21/21, 06:21

  4. core-ci commented on patch set 1 12/21/21, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21329

  5. Stefan Bürk commented on patch set 1 12/21/21, 06:58

    Nightly happy again / green.
  6. Benni Mack voted on patch set 1 V +2 CR +2 12/21/21, 08:06

  7. Benni Mack merged patch set 2 12/21/21, 08:06