Review main Merged

72753[TASK] Port remaining JavaScript unit tests to TypeScript

Benjamin Franzke CR +2 V +2 Expert +634 −563 updated 12/21/21, 12:38

Commit message

Helps to migrate to ES6 modules as that's just
a tsconfig setting then.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 912

  1. Benjamin Franzke uploaded patch set 1 12/21/21, 07:07

  2. Benjamin Franzke wrote 12/21/21, 07:07

    Topic main removed
  3. Benjamin Franzke wrote 12/21/21, 07:07

    Topic set to esm
  4. Benjamin Franzke uploaded patch set 2 12/21/21, 07:14

  5. core-ci voted on patch set 1 V +1 12/21/21, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21330

  6. core-ci voted on patch set 2 V +1 12/21/21, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21331

  7. Benni Mack updated the commit message in patch set 3 12/21/21, 07:53

  8. Benni Mack voted on patch set 3 V +1 CR +1 12/21/21, 07:53

  9. core-ci voted on patch set 3 V +1 12/21/21, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21332

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 12/21/21, 12:08

  11. Benjamin Franzke voted on patch set 3 V +2 CR +2 12/21/21, 12:38

  12. Benjamin Franzke merged patch set 4 12/21/21, 12:38