72753[TASK] Port remaining JavaScript unit tests to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 8
- Build/Sources/TypeScript/backend/Tests/FormEngineValidationTest.tsnew+440 −0
- Build/Sources/TypeScript/backend/Tests/IconsTest.tsnew+65 −0
- Build/Sources/TypeScript/backend/Tests/PopoverTest.tsnew+77 −0
- Build/types/TYPO3/index.d.ts+12 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js+1 −1
- typo3/sysext/backend/Tests/JavaScript/FormEngineValidationTest.js+13 −421
- typo3/sysext/backend/Tests/JavaScript/IconsTest.js+13 −64
- typo3/sysext/backend/Tests/JavaScript/PopoverTest.js+13 −77
Review log 912
-
Benjamin Franzke uploaded patch set 1 12/21/21, 07:07
-
Benjamin Franzke wrote 12/21/21, 07:07
Topic main removed -
Benjamin Franzke wrote 12/21/21, 07:07
Topic set to esm -
Benjamin Franzke uploaded patch set 2 12/21/21, 07:14
-
core-ci voted on patch set 1 V +1 12/21/21, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21330
-
core-ci voted on patch set 2 V +1 12/21/21, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21331
-
Benni Mack updated the commit message in patch set 3 12/21/21, 07:53
-
Benni Mack voted on patch set 3 V +1 CR +1 12/21/21, 07:53
-
core-ci voted on patch set 3 V +1 12/21/21, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21332
-
Christian Kuhn voted on patch set 3 V +1 CR +1 12/21/21, 12:08
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 12/21/21, 12:38
-
Benjamin Franzke merged patch set 4 12/21/21, 12:38