Review main Merged

72754[TASK] Add missing grunt copy action for web-animate polyfill

Benjamin Franzke CR +2 V +2 Hard +53 −339 updated 12/21/21, 12:32

Commit message

Commands executed:
    yarn add web-animate
    yarn build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 79

  1. Benjamin Franzke uploaded patch set 1 12/21/21, 08:16

  2. Benjamin Franzke uploaded patch set 2 12/21/21, 08:17

  3. Benjamin Franzke commented on patch set 2 12/21/21, 08:19

    For reviewers: Please inspect patchset 1, https://review.typo3.org/c/Packages/TYPO3.CMS/+/72754/1 to see that there are no functional changes (only whitespace changes) Patchset 2 then uses the minified variant, so CI+1 on patchset 1 should implicitly verify the integrity of using the minified variant in patchset 2. Hope that makes sense ;)
  4. core-ci voted on patch set 1 V +1 12/21/21, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21335

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/21/21, 08:34

  6. core-ci voted on patch set 2 V +1 12/21/21, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21336

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 12/21/21, 12:06

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 12/21/21, 12:32

  9. Benjamin Franzke merged patch set 3 12/21/21, 12:32