Review main Merged

72755[TASK] Remove stray javascript build outputs

Benjamin Franzke CR +2 V +2 Easy +0 −26 updated 12/21/21, 11:00

Commit message

RecordExportButton.js  has been introduced in #94622 by accident
(probably a left-over from a previous patchset re-added due to grunt watch).

The TypeScript source for Enum/Viewport/TopbarIdentifiers.js has been
removed with #78760, it is unused since then and therefore removed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 2

Review log 78

  1. Benjamin Franzke uploaded patch set 1 12/21/21, 08:49

  2. core-ci voted on patch set 1 V +1 12/21/21, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21338

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 12/21/21, 09:45

  4. Christian Kuhn commented on patch set 1 12/21/21, 09:46

    ok, so we need to keep an eye during reviews when .ts files are removed that the according .js files are removed along the way.
  5. Benjamin Franzke commented on patch set 1 12/21/21, 10:04

    Reply

    Yea, I mean, we could even adapt checkGruntClean to delete (maybe git rm --cached) all javascript sources (excluding known files that are not authored in TypeScript) before running `grunt build`. Then CI should point out these cases. Not high prio right though. These files aren't blockers, just notices them during ES6 module work.
  6. Benni Mack voted on patch set 1 V +1 CR +1 12/21/21, 10:07

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 12/21/21, 11:00

  8. Benjamin Franzke merged patch set 2 12/21/21, 11:00