72755[TASK] Remove stray javascript build outputs
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #96411Stray javascript build output RecordExportButton.js
- Bug #96412Stray javascript build output Enum/Viewport/TopbarIdentifiers.js
- Bug #94545SVG Tree in element browser does not show action icons
- Feature #78760Make pagetree panel resizable/expandable on large screens
- Epic #96323TYPO3 Backend: ES6 Module (ESM) support
Files 2
Review log 78
-
Benjamin Franzke uploaded patch set 1 12/21/21, 08:49
-
core-ci voted on patch set 1 V +1 12/21/21, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21338
-
Christian Kuhn voted on patch set 1 V +1 CR +1 12/21/21, 09:45
-
Christian Kuhn commented on patch set 1 12/21/21, 09:46
ok, so we need to keep an eye during reviews when .ts files are removed that the according .js files are removed along the way. -
Benjamin Franzke commented on patch set 1 12/21/21, 10:04
Reply
Yea, I mean, we could even adapt checkGruntClean to delete (maybe git rm --cached) all javascript sources (excluding known files that are not authored in TypeScript) before running `grunt build`. Then CI should point out these cases. Not high prio right though. These files aren't blockers, just notices them during ES6 module work. -
Benni Mack voted on patch set 1 V +1 CR +1 12/21/21, 10:07
-
Benjamin Franzke voted on patch set 1 V +2 CR +2 12/21/21, 11:00
-
Benjamin Franzke merged patch set 2 12/21/21, 11:00