72758[TASK] Allow ServerRequestInterface in ext:fluid
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 24
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php3+39 −75
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+1 −1
- typo3/sysext/fluid/Classes/View/StandaloneView.php+18 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/CshViewHelper.php+18 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Labels/CshViewHelper.php+23 −37
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php+22 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php+7 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Be/AbstractBackendViewHelper.php+4 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+41 −29
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+25 −49
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormViewHelper.php+15 −22
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php+5 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php+18 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+23 −16
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php+19 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+19 −14
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php+0 −16
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+17 −18
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+60 −86
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+49 −28
Review log 1421
-
Christian Kuhn uploaded patch set 1 12/21/21, 11:25
-
core-ci voted on patch set 1 V +1 12/21/21, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21346
-
Christian Kuhn uploaded patch set 2 12/21/21, 16:50
-
core-ci voted on patch set 2 V +1 12/21/21, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21370
-
Benjamin Franzke commented on patch set 2 12/21/21, 17:08
-
Christian Kuhn commented on patch set 2 12/21/21, 17:55
RenderingContext.php:37ReplyMy goal is to allow running fluid without setting a request at all. From this PoV, it's good that the typo3fluid RenderingContextInterface does not contain these two methads. For extbase, I think we'll end up with a "ExtbaseRenderingContextInterface" that has according methods. -
Christian Kuhn uploaded patch set 3 01/06/22, 11:25
-
core-ci voted on patch set 3 V +1 01/06/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21689
-
Christian Kuhn updated the commit message in patch set 4 01/06/22, 11:40
-
Christian Kuhn commented on patch set 4 01/06/22, 11:41
RenderingContext.php:37ReplyAck -
Christian Kuhn updated the commit message in patch set 5 01/06/22, 11:53
-
core-ci voted on patch set 4 V +1 01/06/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21690
-
core-ci voted on patch set 5 V +1 01/06/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21692
-
Christian Kuhn uploaded patch set 6 01/06/22, 13:31
-
Christian Kuhn uploaded patch set 7 01/06/22, 13:33
-
Stefan Bürk voted on patch set 7 V +1 CR +1 01/06/22, 13:34
-
core-ci voted on patch set 7 V +1 01/06/22, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21697
-
core-ci voted on patch set 6 V +1 01/06/22, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21696
-
Benni Mack voted on patch set 7 V +1 CR +1 01/06/22, 14:07
-
Christian Kuhn voted on patch set 7 V +2 CR +2 01/06/22, 14:47
-
Christian Kuhn merged patch set 8 01/06/22, 14:47
RenderingContext.php:37